Re: [Minios-devel] [PATCH v3 07/43] arm64: change physical_address_offset to paddr_t

[Julien Grall <julien.grall@xxxxxxx>]

Hi Shijie,

On 16/04/18 07:31, Huang Shijie wrote:
> The "uint32_t" is not enough for arm64 code,
> This patch changes it to paddr_t, and also fixes the print format.
>
> Signed-off-by: Huang Shijie <shijie.huang@xxxxxxx>
> ---
>   arch/arm/mm.c         | 2 +-
>   arch/arm/setup.c      | 4 ++--
>   include/arm/arch_mm.h | 5 ++++-
>   3 files changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mm.c b/arch/arm/mm.c
> index f806c9f..3d88d3b 100644
> --- a/arch/arm/mm.c
> +++ b/arch/arm/mm.c
> @@ -6,7 +6,7 @@
>   #include <libfdt.h>
>   #include <lib.h>
>   
> -uint32_t physical_address_offset;
> +paddr_t physical_address_offset;
>   struct e820entry e820_map[1] = {
>       {
>           .addr = 0,
> diff --git a/arch/arm/setup.c b/arch/arm/setup.c
> index b65023c..27bea4a 100644
> --- a/arch/arm/setup.c
> +++ b/arch/arm/setup.c
> @@ -19,7 +19,7 @@ void *device_tree;
>   /*
>    * INITIAL C ENTRY POINT.
>    */
> -void arch_init(void *dtb_pointer, uint32_t physical_offset)
> +void arch_init(void *dtb_pointer, paddr_t physical_offset)
>   {
>       int r;
>   
> @@ -27,7 +27,7 @@ void arch_init(void *dtb_pointer, uint32_t physical_offset)
>   
>       physical_address_offset = physical_offset;
>   
> -    xprintk("Virtual -> physical offset = %x\n", physical_address_offset);
> +    xprintk("Virtual -> physical offset = %"PRIpaddr" \n", 
> physical_address_offset);
While you are here, can you please add '0x' in front of the number? So 
we know it is printed in hexa.
Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel