Re: [Minios-devel] [PATCH v4 00/16] Save/Restore support fro Mini-OS

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Mar 21, 2018 at 11:08:03AM -0700, Bruno Alvisio wrote:
> On Wed, Mar 21, 2018 at 7:04 AM, Wei Liu <wei.liu2@xxxxxxxxxx> wrote:
> 
> > On Wed, Mar 21, 2018 at 09:21:23AM +0000, Wei Liu wrote:
> > > On Thu, Mar 15, 2018 at 08:26:51AM -0700, Bruno Alvisio wrote:
> > > > Hi Wei,
> > > >
> > > > The branch can be found at:
> > > >
> > > > https://github.com/balvisio/mini-os/tree/feature/mini-os-
> > suspend-support-submission-4
> > >
> > > Removed the top commit from that branch and pushed to master.
> >
> > When building mini-os with this series in xen.git
> >
> > checking sys/time.h presence... gcc -mno-red-zone -O1
> > -fno-omit-frame-pointer -O1 -fno-omit-frame-pointer  -m64 -mno-red-zone
> > -fno-reorder-blocks -fno-asynchronous-unwind-tables -m64 -DBUILD_ID
> > -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
> > -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unu
> > sed-local-typedefs   -fno-stack-protector -fno-exceptions -fno-builtin
> > -Wall -Werror -Wredundant-decls -Wno-format -Wno-redundant-decls -Wformat
> > -fno-stack-protector -fgnu89-inline -Wstrict-prototypes -Wnested-externs
> > -Wpointer-arith -Winline -g -D__INSIDE_MINIOS__ -m64 -mno-red-zone
> > -fno-reorder-blocks -fno-asynchron
> > ous-unwind-tables -DCONFIG_PARAVIRT -DCONFIG_START_NETWORK
> > -DCONFIG_SPARSE_BSS -DCONFIG_BALLOON 
> > -D__XEN_INTERFACE_VERSION__=__XEN_LATEST_INTERFACE_VERSION__
> > -isystem /local/work/COMMITTER/xen.git/stubdom/../extras/mini-os/include
> > -D__MINIOS__ -DHAVE_LIBC -isystem /local/work/COMMITTER/xen.git/
> > stubdom/../extras/mini-os
> > /include/posix -isystem /local/work/COMMITTER/xen.git/
> > stubdom/../tools/xenstore/include  -isystem /local/work/COMMITTER/xen.git/
> > stubdom/../extras/mini-os/include/x86 -isystem
> > /local/work/COMMITTER/xen.git/stubdom/../extras/mini-os/include/x86/x86_64
> > -U __linux__ -U __FreeBSD__ -U __sun__ -nostdinc -isystem /local/work
> > /COMMITTER/xen.git/stubdom/../extras/mini-os/include/posix -isystem
> > /local/work/COMMITTER/xen.git/stubdom/cross-root-x86_64/x86_64-xen-elf/include
> > -isystem /usr/lib/gcc/x86_64-linux-gnu/6/include -isystem
> > /local/work/COMMITTER/xen.git/stubdom/lwip-x86_64/src/include -isystem
> > /local/work/COMMITTER/xen.git/stubdom/lwip-
> > x86_64/src/include/ipv4 -I/local/work/COMMITTER/xen.git/stubdom/include
> > -I/local/work/COMMITTER/xen.git/stubdom/../xen/include -isystem
> > /local/work/COMMITTER/xen.git/stubdom/../extras/mini-os/include
> > -D__MINIOS__ -DHAVE_LIBC -isystem /local/work/COMMITTER/xen.git/
> > stubdom/../extras/mini-os/include/posix -isystem /local
> > /work/COMMITTER/xen.git/stubdom/../tools/xenstore/include  -isystem
> > /local/work/COMMITTER/xen.git/stubdom/../extras/mini-os/include/x86
> > -isystem 
> > /local/work/COMMITTER/xen.git/stubdom/../extras/mini-os/include/x86/x86_64
> > -c balloon.c -o /local/work/COMMITTER/xen.git/stubdom/mini-os-x86_64-
> > xenstore/balloon.o
> > yes
> > checking for sys/time.h... yes
> > shutdown.c: In function ‘init_shutdown’:
> > shutdown.c:133:31: error: ‘shutdown_thread’ undeclared (first use in this
> > function)
> >      create_thread("shutdown", shutdown_thread, NULL);
> >                                ^~~~~~~~~~~~~~~
> > shutdown.c:133:31: note: each undeclared identifier is reported only once
> > for each function it appears in
> > minios.mk:68: recipe for target '/local/work/COMMITTER/xen.
> > git/stubdom/mini-os-x86_64-xenstore/shutdown.o' failed
> > make[2]: *** 
> > [/local/work/COMMITTER/xen.git/stubdom/mini-os-x86_64-xenstore/shutdown.o]
> > Error 1
> > make[2]: Leaving directory '/local/work/COMMITTER/xen.
> > git/extras/mini-os-remote'
> > Makefile:582: recipe for target 'xenstore-stubdom' failed
> > make[1]: *** [xenstore-stubdom] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > checking sys/times.h usability...   CC    block-nbd.o
> >
> >
> > You can clone xen.git, apply this patch and build the whole thing to
> > reproduce the error.
> >
> > ---8<---
> > commit 7fa0c5bb8c031ced94709991547cb8e6803733c6
> > Author:     Wei Liu <wei.liu2@xxxxxxxxxx>
> > AuthorDate: Wed Mar 21 12:55:04 2018 +0000
> > Commit:     Wei Liu <wei.liu2@xxxxxxxxxx>
> > CommitDate: Wed Mar 21 12:55:04 2018 +0000
> >
> >     Config.mk: update mini-os commit
> >
> >     Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> >
> > diff --git a/Config.mk b/Config.mk
> > index b5ca57ce90..ef18ca94df 100644
> > --- a/Config.mk
> > +++ b/Config.mk
> > @@ -276,7 +276,7 @@ MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.
> > git
> >  endif
> >  OVMF_UPSTREAM_REVISION ?= 947f3737abf65fda63f3ffd97fddfa6986986868
> >  QEMU_UPSTREAM_REVISION ?= master
> > -MINIOS_UPSTREAM_REVISION ?= 0b4b7897e08b967a09bed2028a79fabff82342dd
> > +MINIOS_UPSTREAM_REVISION ?= 4e6b592a523e3f73950b81f7130c76281e966a05
> >  # Mon Oct 16 16:36:41 2017 +0100
> >  # Update Xen header files again
> 
> 
> I was able to reproduce this error. There are some minor issues with the
> location of the CONFIG_XENBUS macro.
> I will submit a new version of the patch series. I have now tested building
> mini-os while compiling Xen.
> 

Please submit a follow-up patch to fix it. No need to resend the whole
series.

Wei.

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel