[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] Unikraft: Problem with ordering of header files



Hi Bruno,


On 03/12/2018 03:19 PM, Bruno Alvisio wrote:
The issue is that if the header ordering in balloon.c is reversed to the following: Note that now ballon.h comes before mm.h:

#include <uk/plat/balloon.h>
#include <uk/print.h>

#if (defined __X86_32__) || (defined __X86_64__)
#include <xen-x86/mm.h>
#elif (defined __ARM_32__) || (defined __ARM_64__)
#include <xen-arm/mm.h>
#endif

The issue is that xen-x86/mm.h includes a number of files, which include a number of files, ..., which eventually includes uk/config.h, which is the main header file that sets the defines according to your config option.

So, if you want to use any of the CONFIG_* ifdefs, you should include uk/config.h in your header file. If you add "#include <uk/config.h>" in your ballon.h, it will work as you expect it to.

Hope that helps,
Florian

--
Dr. Florian Schmidt
フローリアン・シュミット
Research Scientist,
Systems and Machine Learning Group
NEC Laboratories Europe
Kurfürsten-Anlage 36, D-69115 Heidelberg
Tel.     +49 (0)6221 4342-265
Fax:     +49 (0)6221 4342-155
e-mail:  florian.schmidt@xxxxxxxxx
============================================================
Registered at Amtsgericht Mannheim, Germany, HRB728558

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.