Re: [Minios-devel] [PATCH 13/40] mini-os: remove the e820 from common code

[Huang Shijie <shijie.huang@xxxxxxx>]

On Tue, Nov 07, 2017 at 11:38:24AM +0100, Juergen Gross wrote:
> On 07/11/17 11:14, Julien Grall wrote:
> > Hi Shijie,
> > 
> > On 07/11/17 08:47, Huang Shijie wrote:
> >> On Mon, Nov 06, 2017 at 12:22:43PM +0000, Julien Grall wrote:
> >>>> Change-Id: I6cfa5bcb12128f55b910f72f592e5b43ebd31dd4
> >>>> Jira: ENTOS-247
> >>>> Signed-off-by: Huang Shijie <shijie.huang@xxxxxxx>
> >>>> ---
> >>>>    arch/arm/mm.c | 18 ++++++++++--------
> >>>>    arch/x86/mm.c | 17 +++++++++++++++--
> >>>>    include/mm.h  |  3 +++
> >>>>    mm.c          |  8 ++------
> >>>>    4 files changed, 30 insertions(+), 16 deletions(-)
> >>>>
> >>>> diff --git a/arch/arm/mm.c b/arch/arm/mm.c
> >>>> index 3d88d3b..f600672 100644
> >>>> --- a/arch/arm/mm.c
> >>>> +++ b/arch/arm/mm.c
> >>>> @@ -3,18 +3,20 @@
> >>>>    #include <arch_mm.h>
> >>>>    #include <mini-os/errno.h>
> >>>>    #include <mini-os/hypervisor.h>
> >>>> +#include <mini-os/posix/limits.h>
> >>>
> >>> Why do you need to include that?
> >> The ULONG_MAX needs this header.
> > 
> > ULONG_MAX was used in this file before. So why suddenly this is needed?
> > 
> > If it is because a compilation error, then it should really go in a
> > separate patch...
okay...

> >>> and drop that define.
> >> I think it will make the x86 guys unhappy :)
> >> So I suggest keep the e820 for x86 files.
> > 
> > ... Did you ask them? I really can't see how you will make them unhappy
> > to rename 3 occurrences...
> > 
> > Juergen, Wei, Samuel, any opinion?
> 
> I'm fine with renaming.
okay, I will change it.

Thanks
Huang Shijie

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel