Re: [Minios-devel] [PATCH 36/40] arm64: add the link file

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Shijie,

On 07/11/17 08:39, Huang Shijie wrote:
> On Mon, Nov 06, 2017 at 05:54:30PM +0000, Julien Grall wrote:
> > Hi Shijie,
> >
> > On 03/11/17 03:12, Huang Shijie wrote:
> > > +++ b/arch/arm/arm64/minios-arm64.lds.S
> > > @@ -0,0 +1,76 @@
> > > +#include <pagetable.h>
> > > +
> > > +OUTPUT_FORMAT("elf64-littleaarch64")
> > > +OUTPUT_ARCH(aarch64)
> > > +ENTRY(_start)
> > > +SECTIONS
> > > +{
> > > +  . = (0xffffffffffffffff << (VA_BITS - 1));
> > How did you decide that value?
> Just put the code at the beginning of the virtual address.
> We use the VA_BITS now. Is there something wrong with this?
Yes, this is very confusing to read and as you don't have any 
documentation about the memory layout I can't confirm whether it is valid.
I will comment more when I see more documentation around the layout.

> > > +  _text = .;                   /* Text and read-only data */
> > > +  .text : {
> > > +       *(.text)
> > > +       *(.gnu.warning)
> > > +  }
> > > +
> > > +  _etext = .;                  /* End of text section */
> > > +
> > > +  .rodata : { *(.rodata) *(.rodata.*) }
> > > +  . = ALIGN(PAGE_SIZE);
> > > +  _erodata = .;
> > > +
> > > +  /* newlib initialization functions */
> > > +  . = ALIGN(64 / 8);
> > What's that value?
> I can fix it.
For now, I didn't ask to fix it but explain what is that value.

Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel