Re: [Minios-devel] [MINIOS PATCH v2] Include string.h before console.h

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Wei Liu, on mer. 04 oct. 2017 14:51:26 +0100, wrote:
> Starting from Xen commit af8d93564, it is required to include string.h
> before console.h.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Julien Grall <julien.grall@xxxxxxx>
> Cc: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> 
> After applying this patch to mini-os I will update Xen's Config.mk to
> fix the build failure in xen.git.
> 
> There are quite a few places in the not yet functioning arm port. I opt to
> skip them so that we can unblock staging asap.
> ---
>  lib/sys.c   | 1 +
>  lwip-arch.c | 1 +
>  main.c      | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/lib/sys.c b/lib/sys.c
> index b173bc8..23dc2a5 100644
> --- a/lib/sys.c
> +++ b/lib/sys.c
> @@ -20,6 +20,7 @@
>  
>  #ifdef HAVE_LIBC
>  #include <os.h>
> +#include <string.h>
>  #include <console.h>
>  #include <sched.h>
>  #include <events.h>
> diff --git a/lwip-arch.c b/lwip-arch.c
> index 154617b..21e941e 100644
> --- a/lwip-arch.c
> +++ b/lwip-arch.c
> @@ -8,6 +8,7 @@
>  
>  #include <os.h>
>  #include <time.h>
> +#include <string.h>
>  #include <console.h>
>  #include <xmalloc.h>
>  #include <lwip/sys.h>
> diff --git a/main.c b/main.c
> index 263364c..4e42f53 100644
> --- a/main.c
> +++ b/main.c
> @@ -8,6 +8,7 @@
>  #include <os.h>
>  #include <kernel.h>
>  #include <sched.h>
> +#include <string.h>
>  #include <console.h>
>  #include <netfront.h>
>  #include <pcifront.h>
> -- 
> 2.11.0
> 

-- 
Samuel
<b> j'en ai parlé à xavier, il n'est pas interdit qu'il le change un jour
 -+- #sos - a le bras long vers le chameau -+-

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel