[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [PATCH] Mini-OS: netfront: fix off-by-one error introduced in 7c8f3483



On Mon, Apr 04, 2016 at 11:28:00AM +0100, Wei Liu wrote:
> On Fri, Apr 01, 2016 at 08:26:16PM +0200, Samuel Thibault wrote:
> > 7c8f3483 introduced a break within a loop in netfront.c such that
> > cons and nr_consumed were no longer always being incremented. The
> > offset at cons will be processed multiple times with the break in
> > place.
> > 
> > This commit reverts to using the "some" variable in the loop condition,
> > but avoids ifdefs for the non-libc case. It also renames it to dobreak
> > to make its usage clearer.
> > 
> > Suggested-by: Sarah Newman <srn@xxxxxxxxx>
> > Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
> > Tested-by: Sarah Newman <srn@xxxxxxxxx>
> 
> Queued. Thank you both!

This is now backported to mini-os.git xen-stable-4.6 branch.

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.