Re: [Minios-devel] Double gnttab_end_access in mini-os netfront

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Marek Marczykowski-Górecki, on Tue 08 Dec 2015 12:46:31 +0100, wrote:
> > > http://xenbits.xen.org/gitweb/?p=mini-os.git;a=commit;h=7c8f348390652a67e
> > > 9356eec9cd2b0f76a9c7c72
> > > 
> > > With that commit reverted, issue vanishes.
> > > 
> > > I guess it's because before this commit, there was "if (rx->status ==
> > > NETIF_RSP_NULL) continue" before "gnttab_end_access(buf->gref)", but now
> > > that case is handled after gnttab_end_access (using "if (rx->status >
> > > NETIF_RSP_NULL)"). I think the fix would be to restore that "continue"
> > > line.
> > 
> > That sounds pretty plausible to me (FWIW). Have you tried it?
> 
> I've tried moving gnttab_end_access into that if branch. And it didn't
> worked.

Which if branch?  Please show the code, C is less ambiguous than english
:)

Samuel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel