Re: [Minios-devel] [PATCH ARM v10 2/2] arm: build system

[Thomas Leonard <talex5@xxxxxxxxx>]

On 4 August 2015 at 19:23, Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> wrote:
> Wei Liu, le Tue 04 Aug 2015 10:44:12 +0100, a Ãcrit :
>> On Mon, Aug 03, 2015 at 03:05:08PM +0100, Ian Campbell wrote:
>> > On Thu, 2015-07-23 at 11:08 +0100, Thomas Leonard wrote:
>> > [...]
>> > >  .gitmodules          |  3 +++
>> > [...]
>> > >  dtc                  |  1 +
>> > >
>> > [...]
>> > > diff --git a/.gitmodules b/.gitmodules
>> > > new file mode 100644
>> > > index 0000000..221102d
>> > > --- /dev/null
>> > > +++ b/.gitmodules
>> > > @@ -0,0 +1,3 @@
>> > > +[submodule "dtc"]
>> > > + path = dtc
>> > > + url = git://git.kernel.org/pub/scm/utils/dtc/dtc.git
>> > [...]
>> > > diff --git a/dtc b/dtc
>> > > new file mode 160000
>> > > index 0000000..64c46b0
>> > > --- /dev/null
>> > > +++ b/dtc
>> > > @@ -0,0 +1 @@
>> > > +Subproject commit 64c46b098b969502a74c8b0fd97e6f5e4aa07e21
>> >
>> > I was about to apply when I noticed this and I just wanted to raise the use
>> > of git submodules here explicitly to check folks were OK with it.
>> >
>> > The (or, one) alternative is to import libfdt into the mini-os code based,
>> > which is how both Xen and Linux have approached this issue for in-kernel
>> > use of libfdt (Xen still depends on the normal packaged library for
>> > userspace use).
>> >
>> > Thoughts?
>>
>> FWIW I prefer importing libfdt into mini-os source tree because of the
>> issues you mentioned in next paragraph.
>>
>> But in the end it's mini-os maintainers' call.
>
> Well, I'd say it's the repository maintainers' call :)
> I'm fine with either way.

Hi Ian,

I'm happy to have it imported.

I assume you'd prefer to import it yourself from the git submodule
(only the libfdt subdirectory is required), and don't want me posting
a patch with the entire source of libfdt to the mailing list...


-- 
Dr Thomas Leonard        http://roscidus.com/blog/
GPG: DA98 25AE CAD0 8975 7CDA  BD8E 0713 3F96 CA74 D8BA

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel