Re: [Minios-devel] [PATCH v2] mini-os: enable compiler check for printk format types

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2015-06-24 at 10:43 +0100, Thomas Leonard wrote:
> On 17 June 2015 at 14:33, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> > On Wed, 2015-06-17 at 14:16 +0100, Thomas Leonard wrote:
> >> On 17 June 2015 at 13:47, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:
> >> > On Wed, 2015-06-17 at 11:08 +0100, Thomas Leonard wrote:
> >> >> Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>
> >> >> ---
> >> >> Note: This patch might flag up warnings in downstream projects that use
> >> >> incorrect format codes. In particular, it doesn't include the patch to
> >> >> Xen's vtpm_load_disk, since that's now in a separate repository. See:
> >> >>
> >> >> http://lists.xenproject.org/archives/html/xen-devel/2014-10/msg00899.html
> >> >
> >> > Does such a fixup patch exist somewhere or are you intending to supply
> >> > one?
> >>
> >> The original patch [1] was supposed to fix it, but there was some
> >> issue compiling on 32-bit which I can't reproduce. Do you have e.g. a
> >> docker image with your test environment I could use?
> >
> > I'm afraid not, but my environment is just a plain old Debian Wheezy, so
> > one ought to be easy to find I expect. I do 32-bit builds in a 32-bit
> > chroot, FWIW.
> 
> Is patching Xen still a requirement in order to contribute to Mini-OS?
> I was hoping that having it in its own repository and with its own
> mailing list would remove this requirement. i.e. if an improvement to
> Mini-OS exposes a bug in Xen, then some Xen developer should fix it
> when they update to the new version, rather than blocking the original
> patch.

Right, I'm not blocking on this I just haven't done a commit pass (to
either xen.git or mini-os.git) for a little while, sorry.

The only issue is that it is a little harder for me to compile test
mini-os changes before pushing them without updating xen.git (mainly due
to my own ignorance than any fundamental issue I'm sure).

Ian.


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/minios-devel