[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Embedded-pv-devel] [PATCH v14] This is the ABI for the two halves of a para-virtualized sound driver to communicate with each to other.
- To: Jan Beulich <JBeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- Date: Tue, 29 Nov 2016 18:55:32 +0200
- Cc: lars.kurth@xxxxxxxxxx, iurii.konovalenko@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx, vlad.babchuk@xxxxxxxxx, tim@xxxxxxx, dario.faggioli@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, al1img@xxxxxxxxx, andrii.anisov@xxxxxxxxx, olekstysh@xxxxxxxxx, embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx, julien.grall@xxxxxxx, david.vrabel@xxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, oleksandr.dmytryshyn@xxxxxxxxxxxxxxx, joculator@xxxxxxxxx
- Delivery-date: Tue, 29 Nov 2016 16:55:38 +0000
- List-id: <embedded-pv-devel.lists.xenproject.org>
On 11/29/2016 06:09 PM, Jan Beulich wrote:
On 29.11.16 at 16:24, <andr2000@xxxxxxxxx> wrote:
+struct xensnd_req {
+ uint16_t id;
+ uint8_t operation;
+ uint8_t stream_idx;
+ uint32_t reserved;
+ union {
+ struct xensnd_open_req open;
+ struct xensnd_rw_req rw;
+ uint8_t padding[24];
+ } op;
+};
+
+struct xensnd_resp {
+ uint16_t id;
+ uint8_t operation;
+ uint8_t stream_idx;
+ int8_t status;
+ uint8_t padding[27];
Other than in _req, this ought to be "reserved" imo.
IMO, this is a classic padding, why reserved?
Jan
_______________________________________________
Embedded-pv-devel mailing list
Embedded-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/embedded-pv-devel
|
