Re: [Xen-ia64-devel] RE: [PATCH 0/5] fix fpswa and related issues.

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Thu, Dec 11, 2008 at 09:07:15AM -0700, Alex Williamson wrote:
> On Thu, 2008-12-11 at 09:04 -0700, Alex Williamson wrote:
> > On Thu, 2008-12-11 at 11:05 +0900, Isaku Yamahata wrote:
> > > 
> > > Just to make sure. Is fpswa.efi installed in hvm domain?
> > > You can also confirm it by dh command in efi shell.
> > 
> > Argh, that was it.  I loaded fpswa.efi into my EFI partition after the
> > tests started failing, but I didn't have it in the right location for
> > elilo to pick it up automatically.  Running "load fpswa.efi" makes it
> > work, and copying fpswa.efi to \efi\intel firmware\fpswa.efi also works.
> > I'll add your panic fix and let it run for a while, seems like it's
> > running well now.  Thanks,

Thank you for testing. I'll commit my patches with some clean up.


> One other comment on the patches, I'd recommend removing both instances
> of this:
> 
> printk("ia64_handle_reflection: handling FP trap\n");
> 
> from ia64_handle_reflection().  If we're properly handling the trap,
> this is just unnecessary noise.  Thanks,

Agreed. It should be quietened somehow.

-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel