[Xen-ia64-devel] Re: [PATCH] [ia64] efi: allow efi memory regions to be dumped at boot

[Simon Horman <horms@xxxxxxxxxxxx>]

On Tue, Feb 26, 2008 at 11:13:53AM -0700, Alex Williamson wrote:
> 
> On Tue, 2008-02-26 at 13:42 +0900, Simon Horman wrote:
> > In Linux, when EFI_DEBUG in xen/arch/ia64/linux-xen/efi.c is set to
> > a non-zero value the EFI memory regions, as supplied by the
> > boot parameter are displayed. Unfortunately this doesn't work
> > on Xen as the console is not available at this time.
> 
> Hi Simon,
> 
>    Looks good, but there's already an efi_print in xensetup that should
> be incorporated.  We can currently dump the EFI memory map by passing
> the efi_print option on the xen boot line.  We should keep that
> functionality.  The split printk you're replacing is a bit dubious as
> we're relying on not printing another '\n' in the middle to retain the
> log level.  Thanks,

Hi Alex,

thanks for pointing that out, I wasn't aware of efi_print.
I'll look into consolidating my change into that code.

-- 
Horms


_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel