PATCH: was Re: [Xen-ia64-devel] Re: PATCH: cleanup

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Jeudi 15 Juin 2006 17:29, Alex Williamson a Ãcrit :
> Hi Tristan,
>
>    The CONFIG_PRIVIFY setting is kind of strange to me.  I think I'd
> prefer a #ifdef here:
>
> On Thu, 2006-06-15 at 13:36 +0200, Tristan Gingold wrote:
> > +#if CONFIG_PRIVIFY
> > +               /* Some privified operations are coded using reg+64
>
> Then this:
> >  /* Set to 1 to handle privified instructions from the privify tool.
> > */
> > -static const int privify_en = 0;
> > +#ifndef CONFIG_PRIVIFY
> > +#define CONFIG_PRIVIFY 0
> > +#endif
> > +static const int privify_en = CONFIG_PRIVIFY;
>
> could be
>
> #ifndef CONFIG_PRIVIFY
> static const int privify_en = 0;
> #else
> static const int privify_en = 1;
> #endif
>
> I don't like overloading CONFIG_* with #ifdef and #ifs.  Thanks,
Here is the updated patch (and somewhat completed).

tested by booting dom0.

Tristan.

Attachment: xen-cleanup5.diffs
Description: Text Data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel