[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c
>From: Tristan Gingold [mailto:Tristan.Gingold@xxxxxxxx]
>Sent: 2006?4?21? 15:53
>To: Xu, Anthony; xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; Alex Williamson
>Subject: Re: [Xen-ia64-devel] PATCH [resend]: more case handled in mmio.c
>Le Vendredi 21 Avril 2006 09:45, Xu, Anthony a écrit :
>> One more comment.
>> /* Write high word.
>> FIXME: this is a kludge! */
>> v.u.bits &= 0x3ffff;
>> This seems not be necessary.
>> v is got by stf.spill,
>> stf.spill makes sure the high 47 bits of v.u.bits is 0.
>Yes, this is correct.
>In fact the comment is not correctly placed: the kludge is to do two
The largest size of mmio is 8 byte, if not using pointer in ioreq structure.
And I don't know whether pointer works.
Is that possible to change "uint64_t data" to "long long data"?
Long long type is 16 byte, which is largest size of mmio in ia64.
Xen-ia64-devel mailing list