Re: [Xen-devel] [PATCH v10 8/9] libxl: vnuma nodes placement bits

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-09-03 at 00:24 -0400, Elena Ufimtseva wrote:

> +    /* default setting. */
> +    for (i = 0; i < info->vnodes; i++)
> +        info->vnuma_vnodemap[i] = LIBXC_VNUMA_NO_NODE;

What if the user had specified this?

> +static int libxl__build_vnuma_ranges(libxl__gc *gc,
> +                              uint32_t domid,
> +                              /* IN: mem sizes in megabytes */
> +                              libxl_domain_build_info *b_info,

const please.

> +                              /* OUT: linux NUMA blocks addresses */

More Linux specifics.

> +                              vmemrange_t **memrange)
> +{
> +    /*
> +     * For non-PV domains, contruction of the regions will

"construction"

> +    b_info->vmemranges = b_info->vnodes;

What if the user had specified vmemranges themselves?

Actually, I'm becomign increasingly confused about the fields in the
libxl interface, so I think I'm going to go back to patch #5 to clarify
that before I try to understand any more of this code.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel