Re: [Xen-devel] [PATCH ARM v3 1/7] mini-os: build fixes

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Thomas Leonard, le Wed 11 Jun 2014 11:30:12 +0100, a écrit :
> Make .o rules depend on the includes. Before, only the final link step
> depended on setting up the includes directory, making parallel builds
> unreliable.
> 
> Make symlinks use explicit make rules instead of using a phony target.
> Avoids unnecessary rebuilds.
> 
> Signed-off-by: Thomas Leonard <talex5@xxxxxxxxx>

This makes sense, just one thing:

> +LINKS = include/list.h $(ARCH_LINKS) include/mini-os include/xen 
> include/$(TARGET_ARCH_FAM)/mini-os
> +
> +EXTRA_DEPS += $(LINKS) include/list.h
> +

include/list.h thus appears twice in EXTRA_DEPS.  I guess there is no
need for an intermediate LINKS variable.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel