Re: [Xen-devel] [PATCH] xenstore: set READ_THREAD_STACKSIZE to a sane value

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-03-10 at 17:12 +0000, Ian Jackson wrote:
> Roger Pau Monne writes ("[PATCH] xenstore: set READ_THREAD_STACKSIZE to a 
> sane value"):
> > On FreeBSD PTHREAD_STACK_MIN is 2048 by default, which is obviously
> > too low.

How does this manifest itself? (I suppose this may be answered as part
of answering Ian J)

>  Set the default back to the previous value (16 * 1024), or if
> > that's too low set it to PTHREAD_STACK_MIN.
> 
> The "previous value" is 16K, which was used before
> 35e874b1d5d56dd2098313364b879c637fa56844.  In that commit, Ian C
> wrote:
> 
>     Consindered setting a lower bound but the stack requirements of
>     the watcher thread are pretty minimal (tens of bytes from the
>     looks of it) and unlikely to blow PTHREAD_STACK_MIN on any useful
>     platform.
> 
> I've just re-reviewed the read_thread code and I concur with Ian
> Campbell's assessment.
> 
> So I don't understand why PTHREAD_STACK_MIN isn't sufficient.  Is
> (nearly) that whole amount used by the C runtime system somehow ?
> 
> Thanks,
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel