Re: [Xen-devel] [PATCH 1/6] AMD IOMMU: allocate IRTE entries instead of using a static mapping

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.04.13 at 23:52, suravee suthikulpanit <suravee.suthikulpanit@xxxxxxx> 
>>> wrote:
> I have finally root cause the issue.  Here are the two patches that should 
> help fixing the issue.
> The first patch fixes the issue with the mouse/keyboard not working while 

That's not looking right: update_intremap_entry_from_ioapic() is
very well doing the necessary allocation if none happened at
boot, or at least the code to do so is there. If that one has a bug,
we should aim at fixing it instead of working around the issue. Did
you check that this

    offset = *index;
    if ( offset >= INTREMAP_ENTRIES )
    {
        offset = alloc_intremap_entry(iommu->seg, req_id, 1);
        if ( offset >= INTREMAP_ENTRIES )

in update_intremap_entry_from_ioapic() doesn't take effect for
them?

Also conceptually I don't see why we would want to waste IRTEs
for IO-APIC pins that likely will never get used.

> the second patch
> add a debug-key to help dumping the IRTE which I used to debug the issue.

That one is certainly going to be helpful going forward, but you
should clearly use 'V' as the key just like VT-d does instead of
occupying yet another one.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel