Re: [Xen-devel] [PATCH V2 7/9] libxl_qmp: Introduce libxl__qmp_set_global_dirty_log.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-09-17 at 19:22 +0100, Anthony PERARD wrote:
> This function will enable or disable the global dirty log on QEMU, used during
> a migration.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  tools/libxl/libxl_internal.h |  2 ++
>  tools/libxl/libxl_qmp.c      | 16 ++++++++++++++--
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 9c1482d..acdeeb2 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1399,6 +1399,8 @@ _hidden int libxl__qmp_stop(libxl__gc *gc, int domid);
>  _hidden int libxl__qmp_resume(libxl__gc *gc, int domid);
>  /* Save current QEMU state into fd. */
>  _hidden int libxl__qmp_save(libxl__gc *gc, int domid, const char *filename);
> +/* Set dirty bitmap logging status */
> +_hidden int libxl__qmp_set_global_dirty_log(libxl__gc *gc, int domid, bool 
> enable);
>  /* close and free the QMP handler */
>  _hidden void libxl__qmp_close(libxl__qmp_handler *qmp);
>  /* remove the socket file, if the file has already been removed,
> diff --git a/tools/libxl/libxl_qmp.c b/tools/libxl/libxl_qmp.c
> index aac06c2..befa11b 100644
> --- a/tools/libxl/libxl_qmp.c
> +++ b/tools/libxl/libxl_qmp.c
> @@ -660,7 +660,6 @@ static void qmp_parameters_add_string(libxl__gc *gc,
>      qmp_parameters_common_add(gc, param, name, obj);
>  }
>  
> -#if 0
>  static void qmp_parameters_add_bool(libxl__gc *gc,
>                                      libxl__json_object **param,
>                                      const char *name, bool b)
> @@ -670,7 +669,6 @@ static void qmp_parameters_add_bool(libxl__gc *gc,
>      obj = libxl__json_object_alloc(NOGC, JSON_TRUE);
>      qmp_parameters_common_add(gc, param, name, obj);
>  }
> -#endif
>  
>  #define QMP_PARAMETERS_SPRINTF(gc, args, name, format, ...) \
>      qmp_parameters_add_string(gc, args, name, \
> @@ -919,6 +917,20 @@ int libxl__qmp_resume(libxl__gc *gc, int domid)
>      return qmp_run_command(gc, domid, "cont", NULL, NULL, NULL);
>  }
>  
> +int libxl__qmp_set_global_dirty_log(libxl__gc *gc, int domid, bool enable)
> +{
> +    libxl__json_object *args = NULL;
> +    int rc = 0;
> +
> +    qmp_parameters_add_bool(gc, &args, "enable", enable);
> +
> +    rc = qmp_run_command(gc, domid, "xen-set-global-dirty-log", args,
> +                         NULL, NULL);
> +    libxl__json_object_free(gc, args);
> +
> +    return rc;
> +}
> +
>  int libxl__qmp_initializations(libxl__gc *gc, uint32_t domid,
>                                 const libxl_domain_config *guest_config)
>  {



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel