Re: [Xen-devel] [PATCH 2/4] xen: add xen parameter to control A/D bits support

["Hao, Xudong" <xudong.hao@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Tuesday, June 19, 2012 5:57 PM
> To: Hao, Xudong
> Cc: Shan, Haitao; Zhang, Xiantao; xen-devel@xxxxxxxxxxxxx; keir@xxxxxxx
> Subject: Re: [PATCH 2/4] xen: add xen parameter to control A/D bits support
> 
> >>> On 19.06.12 at 08:28, Xudong Hao <xudong.hao@xxxxxxxxx> wrote:
> > @@ -1574,6 +1579,9 @@ struct hvm_function_table * __init
> start_vmx(void)
> >          if ( cpu_has_vmx_ept_1gb )
> >              vmx_function_table.hap_capabilities |=
> HVM_HAP_SUPERPAGE_1GB;
> >
> > +        if ( cpu_has_vmx_ept_ad_bits )
> > +            hap_has_access_bit = hap_has_dirty_bit = 1;
> 
> So you're using these flags here, ...
> 
> > +
> >          setup_ept_dump();
> >      }
> >
> > --- a/xen/include/asm-x86/hap.h
> > +++ b/xen/include/asm-x86/hap.h
> > @@ -64,6 +64,9 @@ int   hap_track_dirty_vram(struct domain *d,
> >
> >  extern const struct paging_mode *hap_paging_get_mode(struct vcpu *);
> >
> > +extern int hap_has_dirty_bit __read_mostly;
> > +extern int hap_has_access_bit __read_mostly;
> 
> ... and you're declaring them here, but I fail to find their definition.
> How does the result of applying up to this patch build?
> 

The definition is in patch 3, I'll move them in this patch.

> Also, they should clearly be bool_t.
> 

Thanks, I'll use type bool_t instead of int.

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel