[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 03/19] libxl: domain restore: reshuffle, preparing for ao
Ian Campbell writes ("Re: [Xen-devel] [PATCH 03/19] libxl: domain restore:
reshuffle, preparing for ao"):
> On Fri, 2012-06-08 at 18:34 +0100, Ian Jackson wrote:
> > We are going to arrange that libxl, instead of calling
> > xc_domain_restore, calls a stub function which forks and execs a
> > helper program, so that restore can be asynchronous rather than
> > blocking the whole toolstack.
> > * Move the contents of domain_restore into its correct place in the
> > domain creation sequence. We put it inside
> > domcreate_bootloader_done, which now either calls
> "either" but no "or"? I suppose the or case is call
> domcreate_rebuild_done directly?
Yes. I have completed this sentence.
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> I confirmed at a high level that the same blocks of code exist and are
> called in the same overall order, but I didn't do a line by line
> comparison of the blocks in question, assuming they really are mostly
> motion and adjustments for the new context.
Right. I did some semi-mechanical checks to confirm that assertion,
after the last round of hideous merge conflict doom.
Xen-devel mailing list