[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v5 05/10] libxl: convert libxl_device_nic_add to an async operation
Roger Pau Monne writes ("[PATCH v5 05/10] libxl: convert libxl_device_nic_add
to an async operation"):
> This patch converts libxl_device_nic_add to an ao operation that
> waits for device backend to reach state XenbusStateInitWait and then
> marks the operation as completed. This is not really useful now, but
> will be used by latter patches that will launch hotplug scripts after
> we reached the desired xenbus state.
> Calls to libxl_device_nic_add have also been moved to occur after the
> device model has been launched, so when hotplug scripts are called
> from this functions the interfaces already exists.
This is now a lot smaller, excellent.
> -int libxl_device_nic_add(libxl_ctx *ctx, uint32_t domid, libxl_device_nic
> +int libxl_device_nic_add(libxl_ctx *ctx, uint32_t domid, libxl_device_nic
> + const libxl_asyncop_how *ao_how)
> - GC_INIT(ctx);
> + AO_CREATE(ctx, domid, ao_how);
> + libxl__ao_device *device;
Can we call that variable `aodev' ? Elsewhere `device' is a
Xen-devel mailing list