[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] x86/amd: fix crash as Xen Dom0 on AMD Trinity systems
- To: Ingo Molnar <mingo@xxxxxxxxxx>
- From: Borislav Petkov <bp@xxxxxxxxx>
- Date: Wed, 6 Jun 2012 11:42:54 +0200
- Cc: Andre Przywara <andre.przywara@xxxxxxx>, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Jacob Shin <jacob.shin@xxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Jan Beulich <JBeulich@xxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>, mingo@xxxxxxx, tglx@xxxxxxxxxxxxx
- Delivery-date: Wed, 06 Jun 2012 09:43:12 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1338975776; bh=cRTwXA8/2M5cw30LPFD7QzOpjOS9oa7uTLVHUcrmsuU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=gV7Ml2qIOhVc3qxPIg1ARh1ZfwKFiHo5N3ypzP TDmF6E0FtClcmPHdrZmWON1vCfEkbybIPAPpsgSZpsyL+weYzYAZ9+59CsvAjEZHvLY 1mDzrU+FBT0yCCl4E4iizRmlEB7GZ0KFD+CVhpMN3PCpm4i9hghX+gJ4xem/TboitY=
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1338975775; bh=cRTwXA8/2M5cw30LPFD7QzOpjOS9oa7uTLVHUcrmsuU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=KC3ZPH2MzOIa0tk4nTB5+5mP6dDMErAEGHAnSp GOy2ftqS2f1jJo29ITt6jYMIU1PFEGclD5Au/TWBGlh89aTh+at+KvJ8pZVu1/qh49o ASX/ycibwVslWiiRxZUQvuMY1/Dk3PcMaaxf0qlXlr7iZAU/igbvgTYy/R7fVrY/GA=
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
- Mail-followup-to: Borislav Petkov <bp@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Jacob Shin <jacob.shin@xxxxxxx>, Andre Przywara <andre.przywara@xxxxxxx>, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Jan Beulich <JBeulich@xxxxxxxx>, mingo@xxxxxxx, tglx@xxxxxxxxxxxxx
On Wed, Jun 06, 2012 at 11:27:13AM +0200, Ingo Molnar wrote:
>
> * H. Peter Anvin <hpa@xxxxxxxxx> wrote:
>
> > On 05/30/2012 03:33 PM, Konrad Rzeszutek Wilk wrote:
> > > diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> > > index 75f33b2..e74df95 100644
> > > --- a/arch/x86/xen/enlighten.c
> > > +++ b/arch/x86/xen/enlighten.c
> > > @@ -1116,7 +1116,10 @@ static const struct pv_cpu_ops xen_cpu_ops
> > > __initconst = {
> > > .wbinvd = native_wbinvd,
> > >
> > > .read_msr = native_read_msr_safe,
> > > + .rdmsr_regs = native_rdmsr_safe_regs,
> > > .write_msr = xen_write_msr_safe,
> > > + .wrmsr_regs = native_wrmsr_safe_regs,
> > > +
> > > .read_tsc = native_read_tsc,
> > > .read_pmc = native_read_pmc,
> > >
> >
> > Okay, tell me again:
> >
> > why do we have these hooks again? Can we please weed out
> > paravirt methods that have no users?
>
> ping?
I think we solved all that and hpa wanted to queue them up shortly:
http://marc.info/?l=linux-kernel&m=133856342618027&w=2
If it's easier, I can send you a pull request later.
Thanks.
--
Regards/Gruss,
Boris.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel