[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] xl.cfg: document the cpuid= option
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: George Dunlap <dunlapg@xxxxxxxxx>
- Date: Wed, 6 Jun 2012 10:20:59 +0100
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 06 Jun 2012 09:21:15 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=59O5P7Dlt8TiAzzoUm3Jx5twodEyUmjoBzFgQ3TVSrc=; b=VIKaQDIkmKWbIXS92NerupNz0OHjvHhxGDzI8hyrVeQoQXYz4gIynrZD/3pQ0n+Pbv 0jyMHqswygeQzOEWO2nTFIC67cAZP9ps9AfcO8Uo+p+h43nMTe/BwW3zpER2yfenVXm0 4SPwTIdMX7bQ5tPnBOAVezcZokUse7JXYX9Yhnkhfa7HKRrvwsbbaq9wdMgpl+zGwR3+ LQEhAOFcoyV+QPVQASIzxGoYrZQWnWxFgoCyCwH8IRrbz0uQ+cfJIK4MzUvCoV1VmVZG QwutIsyr8IxqA3VBgUje+QnCgLYXTLEtp0hS27UbSOoJK3fNiPx8ehjfcYwfgSBrOtR1 ir3g==
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Fri, Jun 1, 2012 at 6:48 PM, Olaf Hering <olaf@xxxxxxxxx> wrote:
> # HG changeset patch
> # User Olaf Hering <olaf@xxxxxxxxx>
> # Date 1338572607 -7200
> # Node ID 3da83ff08d6b6431c104a431d6617ccb5977643b
> # Parent fde8ad0252ee6ddb8d71dda869db3b20b3d9ca62
> xl.cfg: document the cpuid= option
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>
> diff -r fde8ad0252ee -r 3da83ff08d6b docs/man/xl.cfg.pod.5
> --- a/docs/man/xl.cfg.pod.5
> +++ b/docs/man/xl.cfg.pod.5
> @@ -969,9 +969,47 @@ XXX
>
> XXX
>
> -=item B<cpuid=XXX>
> +=item B<cpuid="STRING"> or B<cpuid=[ "XEND_STRING", "XEND_STRING" ]>
>
> -XXX
> +Configure guest CPUID responses.
I think I would say, "Configure the value returned when a guest
executes CPUID instruction". ("Response" is a technical term that
doesn't really seem to fit here, I think.)
> Two config versions of config syntax are
> +recognized: xend and libxl.
It's not clear from this text -- will libxl understand the xend format?
Other than that, the explanation and the example look really good.
(NB, I haven't reviewed for accuracy.)
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel