Re: [Xen-devel] [PATCH] Fix pygrub install.

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On 01/06/12 11:11, George Dunlap wrote:
> On 01/06/12 09:29, Ian Campbell wrote:
> > >  On Thu, 2012-05-31 at 10:54 +0100, Anthony PERARD wrote:
> > > >>  On Thu, May 31, 2012 at 10:42 AM, George Dunlap
> > > >>  <George.Dunlap@xxxxxxxxxxxxx>   wrote:
> > > > >>>  The strange thing is that there*is*  a pygrub in the right place, so
> > > > >>>  it appears that thefollowing line ($INSTALL_PYTHON_PROG) is redundant?
> > > >>  It's seems that the right on the script are already set to 755 by the
> > > >>  setup.py, so this $INSTALL_PYTHON_PROG line is probably an extra.
> > >  What is the conclusion here? Is the original patch correct and/or is
> > >  there a subsequent additional fix?
> There is a bug (pygrub is installed both in $(DESTDIR)/foo and
> $(DESTDIR)/$(DESTDIR)/foo), and Anthony's first patch (AFAICT) correctly
> fixes the bug (only installed in $(DESTDIR).
>
> I think there is a redundant command in the Makefile as well, where
> pygrub will be copied to $(DESTDIR)/foo twice.  That doesn't cause
> incorrect behavior, but I would probably still consider it a bug.
>
> So the original patch is correct, but there is a subsequent fix.
I'll send a patch that remove this extra line as the pygrub script is 
copied by setup.py.
--
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel