[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH RFC V6 2/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration
- To: Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>
- From: Avi Kivity <avi@xxxxxxxxxx>
- Date: Sun, 29 Apr 2012 16:27:58 +0300
- Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, X86 <x86@xxxxxxxxxx>, Gleb Natapov <gleb@xxxxxxxxxx>, KVM <kvm@xxxxxxxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, LKML <linux-kernel@xxxxxxxxxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxx>, Alexander Graf <agraf@xxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Randy Dunlap <rdunlap@xxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Srivatsa Vaddagiri <vatsa@xxxxxxxxxxxxxxxxxx>, Sasha Levin <levinsasha928@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Virtualization <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
- Delivery-date: Sun, 29 Apr 2012 13:28:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 04/23/2012 01:00 PM, Raghavendra K T wrote:
> From: Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>
>
> Signed-off-by: Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>
> ---
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 6faa550..7354c1b 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5691,7 +5691,9 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
> int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
> struct kvm_mp_state *mp_state)
> {
> - mp_state->mp_state = vcpu->arch.mp_state;
> + mp_state->mp_state = (vcpu->arch.mp_state == KVM_MP_STATE_HALTED &&
> + vcpu->arch.pv.pv_unhalted) ?
> + KVM_MP_STATE_RUNNABLE : vcpu->arch.mp_state;
> return 0;
> }
Not pretty. Suggest rewriting using an if.
--
error compiling committee.c: too many arguments to function
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel