[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] libxl: Query VNC listening port through QMP
On 18/04/12 12:05, Ian Campbell wrote:
On Tue, 2012-04-17 at 16:45 +0100, Anthony PERARD wrote:On 17/04/12 16:30, Ian Campbell wrote:On Mon, 2012-04-16 at 19:15 +0100, Anthony PERARD wrote:Currently `xl vncviewer $dom` does not work because the VNC port is not registered in xenstore when using qemu-upstream. This patch attempted to fix this.libxl_vncviewer_exec also potentially reads vnc-pass, although frankly having such a thing in xenstore strikes me as something of a misfeature...Well, I thought of that, but when I tried `xl vncviewer` with a password set, the result was that vncviewer asked me a password. That why I haven't put more effort in querrying the vnc password from QEMU.Same here even with qemu-xen-traditional.
There is actually an option to xl vncviewer: --autopass, so with this, no need to enter the vnc pass manually. And it's works fine with the traditionnal.
I'm tempted to suggest that we remove this support -- having plain text passwords in xenstore (thankfully with perms set somewhat sanely) just doesn't seem like a Good Thing to me...
-- Anthony PERARD _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
Lists.xenproject.org is hosted with RackSpace, monitoring our