[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 10 of 18] tools/libvchan: fix build errors caused by -Werror in node-select.c
On Mon, 2012-04-02 at 20:54 +0100, Olaf Hering wrote:
> On Mon, Apr 02, Ian Jackson wrote:
> > Olaf Hering writes ("[Xen-devel] [PATCH 10 of 18] tools/libvchan: fix build
> > errors caused by -Werror in node-select.c"):
> > > node-select.c: In function 'vchan_wr':
> > > node-select.c:60:2: warning: ISO C90 forbids mixed declarations and code
> > > [-Wdeclaration-after-statement]
> > This one is a question of coding style. Apparently libvchan uses
> > mixed statements/declarations, so this should be fixed by changing the
> > warning flags.
> This is from xen itself:
> .. -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement ..
> Are you saying -Wdeclaration-after-statement should be removed?
No, if appropriate to do so then it should be removed from
tools/libvchan like we do in tools/libxl.
However skimming over node-select.c and io.c (as another random file) it
looks like the use of mixed declarations and code is the exception not
the rule even within libvchan, so I think it would be fine to fix the
two places where this isn't the case.
> diff -r 7c29b8723556 Config.mk
> --- a/Config.mk
> +++ b/Config.mk
> @@ -161,7 +161,7 @@ CFLAGS += -Wall -Wstrict-prototypes
> # and is over-zealous with the printf format lint
> CFLAGS-$(clang) += -Wno-parentheses -Wno-format
> -$(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wdeclaration-after-statement)
> +$(call cc-option-add,HOSTCFLAGS,HOSTCC,-Wno-declaration-after-statement)
> $(call cc-option-add,CFLAGS,CC,-Wdeclaration-after-statement)
> $(call cc-option-add,CFLAGS,CC,-Wno-unused-but-set-variable)
> Xen-devel mailing list
Xen-devel mailing list