[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 0 of 2] x86/mm: Unsharing ENOMEM handling
At 11:29 -0400 on 12 Mar (1331551776), Andres Lagar-Cavilla wrote:
> These two patches were originally posted on Feb 15th as part of a larger
> They were left to simmer as a discussion on wait queues took precedence.
> Regardless of the ultimate fate of wait queues, these two patches are
> as they solve some bugs on the memory sharing side. When unsharing fails,
> domains would spin forever, hosts would crash, etc.
> The patches also clarify the semantics of unsharing, and comment how it's
> Two comments against the Feb 15th series taken care of here:
> - We assert that the unsharing code can only return success or ENOMEN.
> - Acked-by Tim Deegan added to patch #1
I'm a bit uneasy about the way this increases the amount of boilerplate
and p2m-related knowledge that's needed at call sites, but it fixes real
problems and I can't see an easy way to avoid it.
Xen-devel mailing list