[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2] autoconf: check for Python.h header and -lpython* lib
- To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
- From: Roger Pau Monnà <roger.pau@xxxxxxxxxxxxx>
- Date: Mon, 12 Mar 2012 14:35:39 +0100
- Cc: "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
- Delivery-date: Mon, 12 Mar 2012 13:36:40 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=YPMLshXvsXYLfkqK6qWZAzd7BrBN3GD8B4FagwNvfbI=; b=eZpWuLUDcOulKmto9368F9FrkNNg1O6s/UIQDB/uUyqi4QtN0/WDwha0hzy8v6323H dZntRPpzwAIfFzMWF/23HtrL7lAW24OceMncpBgneHN4iKwQKV6UjDhsie2yVhWtL8Ir jGfM9oi1zrw3Fh3QZYEXG50zkrzSFtt4olbfJ/MY0n9+gxidYVkUJL/GmQ3XQ+s8M5bR x1qKyFfdQ4qtIlY2hnrCdV+g0uPN9yrJi+n6OP6qWUdsylK00N+vkFHOSekOxpAZYwZZ yzbmh1YJmDx03adFTNCqyRZecOtIAJi4RSo3g7F/txN+3abfa9FiQc01MkJ9KAtY63Ny cd1g==
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
2012/3/12 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> Roger Pau Monne writes ("[PATCH v2] autoconf: check for Python.h header and
> -lpython* lib"):
>> autoconf: check for Python.h header and -lpython* lib
>
> Right, this is better.
>
>> +ac_previous_cppflags=$CPPFLAGS
> ...
>> +AC_CHECK_HEADER([Python.h], [],
>> + Â Â[AC_MSG_ERROR([Unable to find Python development headers])],)
>> +AC_CHECK_LIB($python_lib, PyArg_ParseTuple, [],
>> + Â Â[AC_MSG_ERROR([Unable to find a suitable python development library])])
>> +CPPFLAGS=$ac_previous_cppflags
>> +LDLFAGS=$ac_previous_ldflags
>
> But AFAICT we go to all this effort to find the right python flags and
> then we throw them away. ÂThis is a bit odd. ÂShouldn't we be passing
> this in some PYTHON_FOOFLAGS variables for the benefit of tools/python ?
This would only be needed to compile Python C modules, but since
python uses it's own standart build script (tools/python/setup.py) and
we already pass to the setup.py script the desired python version to
use, it already fetches the necessary includes/libs using it's own
mechanisms.
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel