[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 5 of 9 v2] libxl: wait for devices to initialize upon addition to the domain
2011/11/18 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> It would be better to use the XenbusStateFoo constants than the numbers.
> This also applies to the prviosu patch, I just didn't think of it...
Done, I had to include xen/io/xenbus.h to libxl_internal.h to be able
to use XenbusState*.
> Otherwise this looks good.
> I'm a little concerned about the synchronous wait here (since it will
> serialise adding all devices). Eventually it should be possible to do
> all the adds and then wait for them all but this is dependent on the
> event infrastructure.
When the OS event patch is added to libxl we will be able to call the
hotplug scripts from the event handler, so we should no longer need to
wait for devices to initialize synchronously.
Xen-devel mailing list