Re: [Xen-devel] [PATCH 9 of 9] Modify all call sites of queries into the p2m to use the new fine-grained locking

[andres@xxxxxxxxxxxxxxxx]

I don't know that a massive sed on all these names is a good idea. I guess
forcing everyone to compile-fail will also make them realize they need to
add a call to drop the p2m locks they got...

Can you elaborate on the naming preferences here: would you prefer
gfn_to_mfn/put_gfn? get_p2m_gfn/put_p2m_gfn? get_gfn/put_gfn

Andres

> At 00:33 -0400 on 27 Oct (1319675634), Andres Lagar-Cavilla wrote:
>>  28 files changed, 519 insertions(+), 101 deletions(-)
>
> And I thought patch 5 was big :)
>
> I'm not going to read the detail of this this time around - I'd like to
> only have to review it once. :)
>
> I wonder whether it would be worth changing the name/signature of the
> generic p2m functions in an incompatime way while we're there.  It would
> have three advantages:
>
>  - allow the lookup/drop pairs to have nice matching names
>  - get rid of the confusingly-named 'gmfn_to_mfn' function
>  - avoid later bugs if patches are forward-ported across this chaneg
>    that add p2m lookups (but not corresoponding drops)
>
> Tim.
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel