[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 2 of 7] [OCAML] Remove the uuid library
On Fri, 2011-09-30 at 13:21 +0100, Jonathan Ludlam wrote:
> On 30 Sep 2011, at 08:45, Ian Campbell wrote:
> > On Thu, 2011-09-29 at 22:17 +0100, Jon Ludlam wrote:
> >> diff -r c5df5f625ee2 -r 42cdb34ec175 tools/ocaml/libs/xc/META.in
> >> --- a/tools/ocaml/libs/xc/META.in
> >> +++ b/tools/ocaml/libs/xc/META.in
> >> @@ -1,5 +1,5 @@
> >> version = "@VERSION@"
> >> description = "Xen Control Interface"
> >> -requires = "mmap,uuid"
> >> +requires = "unix,mmap"
> >> archive(byte) = "xc.cma"
> >> archive(native) = "xc.cmxa"
> > Is the addition of unix here really part of removing uuid? I don't see
> > any additional use of unix arising from the change.
> No, you're correct - it's a bugfix in the dependencies. I can prepare it as a
> separate patch, if you want?
I you need to resend the series anyway you may as well I suppose, but if
not then its not a big deal for me at least.
> > xc does seem to use unix already so the change is probably correct, just
> > not really part of this change. I'd be happier if it went in separately,
> > but:
> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Xen-devel mailing list