[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [PATCH 08/13] xen/pvticketlock: disable interrupts while blocking
- To: Andi Kleen <andi@xxxxxxxxxxxxxx>
- From: Don Zickus <dzickus@xxxxxxxxxx>
- Date: Tue, 13 Sep 2011 15:21:52 -0400
- Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, Marcelo Tosatti <mtosatti@xxxxxxxxxx>, Nick Piggin <npiggin@xxxxxxxxx>, KVM <kvm@xxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Avi Kivity <avi@xxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 13 Sep 2011 12:33:13 -0700
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
On Tue, Sep 13, 2011 at 09:03:20PM +0200, Andi Kleen wrote:
> > So I got around to implementing this and it seems to work great. The back
> > to back NMIs are detected properly using the %rip and that info is passed to
> > the NMI notifier. That info is used to determine if only the first
> > handler to report 'handled' is executed or _all_ the handlers are
> > executed.
> > I think all the 'unknown' NMIs I generated with various perf runs have
> > disappeared. I'll post a new version of my nmi notifier rewrite soon.
> This will fail when the system is idle.
Heh. I don't think I explained what I was doing properly.
I had a bunch of perf runs going simultaneously on my Core2quad. Probably
generated around 40,000 NMIs in a few minutes. I think around a 1000 or
so detected back-to-back NMIs.
With the current NMI detection algorithm in perf to determine back-to-back
NMIs, I can usually use the above scenario to generate an 'unknown' NMI.
Actually numerous ones before the box freezes. It is a false positive.
With my current code and Avi's idea, all those disappeared as they are now
'swallowed' by the algorithm. That seemed like a positive.
However, being cautious, I decided to instrument lkdtm to inject NMIs to
force unknown NMI conditions
I tried to inject the NMIs while my trace_printk buffer was flooding my
screen with 'back-to-back NMIs detected'. I did this 4 or 5 times and
every single one of them were detected as an 'unknown' NMI. So this was
good too, in the sense it was not swallowing 'real' unknown NMIs.
Does that make sense?
Or are you saying an NMI in an idle system will have the same %rip thus
falsely detecting a back-to-back NMI?
Xen-devel mailing list