[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 0 of 4] xentrace [v2]: non-contiguous allocation of per-cpu buffer
- To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
- From: Keir Fraser <keir@xxxxxxx>
- Date: Fri, 20 May 2011 09:36:30 +0100
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 20 May 2011 01:37:51 -0700
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to:cc :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=uNA1nAqSw18yLOHjQsV3pU69Jn9r157vHkm/7522I00=; b=wPij4NRkgc5LDZ+SsCdv1jkOCZGzNs9U1p9YtsZpTc1A0yhRxlX6KAhf3OfrfEuduh 74MokTIAhQHsDh6pSNrdq1a2QzejaOp4b2vn9CIAsJxtJ1jAxIzuZmStXUTGEf3TttAH YsW+aNEbgRm1hjeS+7UDyv96Rm9hZ31OMTJck=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=tJNpkM5T9y/IbuJzp4iEnNtX7Al+GNs7fPO87itEp/x0SVtxWJUFmf+bu2+vwTRXm1 hnQ+zKwqjh0QoYu0P66zot8UT/jId+6POYOEdg2g6+IMUhpTZ6R3NaBAnV1BBvJ7/VPW YlPdEuW+P6dmSfoyc/SipQKbetBn4ge88kVkU=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
- Thread-index: AcwWyQQa04vS7EHbiEuIUwYOiX2ULg==
- Thread-topic: [Xen-devel] [PATCH 0 of 4] xentrace [v2]: non-contiguous allocation of per-cpu buffer
On 10/05/2011 15:32, "Olaf Hering" <olaf@xxxxxxxxx> wrote:
> This series implements non-contiguous trace buffers.
I haven't seen an Ack for these yet.
-- Keir
> There was an overflow in the offset calculation because it was stored in
> an int. Also the calculation of the per-cpu buffer did not take the type
> of the offset value into account. This was the reason why I ran into the
> checks in bogus(). The crash in out_dealloc: was caused by the lack of
> check for the offset value.
>
> Regarding the math added to next_record() another array of pointers could be
> added to remove the mfn_to_virt() calls. In my testing 9343 trace pages on 8
> cpus are used. Such an array would required additional (9343*8*8)/1024=583Kb.
> Which is not too much, given the amount of 291MB tracebuffers.
> Such a change is not part of this series.
>
> Olaf
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel