[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] regression from c/s 22071:c5aed2e049bc (ept: Put locks around ept_get_entry) ?
- To: Jan Beulich <JBeulich@xxxxxxxxxx>
- From: Keir Fraser <keir@xxxxxxx>
- Date: Thu, 16 Dec 2010 20:34:50 +0000
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 16 Dec 2010 12:35:37 -0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type; bh=MM/8D4xa0ajnH+hVWIzwCLFZDjBnSxTigKGpILlLHTw=; b=ddmQtAGJySfQztLeURRPPXBfM6fgNrPw0qzfVaOaxQxBqcC0eFmEccH6slgJBh6uiv AuDjd19FiMJQzfJVaQTq6gq6qrU5XXdxcYXAGYsUfjSnHNBGgSPkDy5cOa1eywT5q3jM U8xRWU5pusBmdZTY4FGzyuwI7aIA0vlXZueYU=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type; b=lAkZ8UlBJOakO7CY/GZAEMi1QWRjF06MHK7U5L65fDUG4KDeWgNEiaHykYqL6RXv31 iazSE6wsjD2DyRTf3BzBgrm8sBKO7VjyU6SarTA7uv/GJ2b7sIlYTAggUJwLJLItTLys XuxKjOJGsisM+I3K5w87jLos9GPCo5QeA6q5g=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
- Thread-index: AcudQx57xcyHiSTYCk6266TOuiPtnAAHZEzX
- Thread-topic: [Xen-devel] regression from c/s 22071:c5aed2e049bc (ept: Put locks around ept_get_entry) ?
On 16/12/2010 17:03, "Keir Fraser" <keir@xxxxxxx> wrote:
> On 16/12/2010 16:50, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>
>>> approach therefore. Perhaps *(volatile type *)px = x or, really, even better
>>> I should define some {read,write}_atomic{8,16,32,64} accessor functions
>>> which use inline asm to absolutely definitely emit a single atomic 'mov'
>>> instruction.
>>>
>>> Make sense?
>>
>> Yes.
>
> Excellent. I will lay groundwork and fix pte_{read,write}_atomic directly in
> -unstable and -4.0-testing. I will then post a proposed fix for EPT to the
> list. I don't know that code so well and I may not otherwise catch all
> places that require use of the new accessor macros.
Attached is a patch I've knocked up for p2m-ept.c. I don't know how complete
it really is. Perhaps someone (George?) would like to Ack it as is, or
develop it further.
-- Keir
> -- Keir
>
>> Jan
>>
>
>
Attachment:
00-ept-atomic
Description: Binary data
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel