[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] libxl: Use xenbus to communicate with xenstore if the socket fails
Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: Use xenbus to communicate
with xenstore if the socket fails"):
> On Fri, 2010-12-10 at 11:39 +0000, Mihir Nanavati wrote:
> > Sorry, that was rather confusing ;) Hope this reads better.
Thanks for the patch.
> Much, thanks!
> I think "int mode" should be "unsigned long flags" but don't feel that
> strongly so:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
It should be unsigned of some kind, surely, and you're right about the
name I'll fix that up.
> (If you are submitting as an attachment I think IanJ/Stefano will prefer
> if you duplicate the changelog in the attachement as well as in the body
> so they don't need to reconstruct the commit)
In general, I would definitely prefer it if revised patches contained
a fresh copy of the original changelog comment, with a notes about
what changed, if applicable. That saves going back in the thread
trying to find which message has the changelog comment and trying to
decide whether the old comment still applies. I'm not that bothered
about the exact format.
In this case I think the original comment from the top of the thread
Xen-devel mailing list