[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] reserved words in tmem.h
- To: James Harper <james.harper@xxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
- From: Keir Fraser <keir@xxxxxxx>
- Date: Fri, 10 Dec 2010 11:17:41 +0000
- Cc:
- Delivery-date: Fri, 10 Dec 2010 03:19:20 -0800
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=lRAXla4K2rJy/I7ktwGAVVn+nqqmaEy5m3GCg9qmTMA=; b=HEQNAqNCAp12I4d3Zcyp5Vf7nyOIjA96hAuAQqYIS/lKCf/HHoNoknje9vOZ46M9H9 h2W2VMAIB9Yu/ZUo+lBBfIMnB3BGPcF96UrWnfbs98NTaW8rDsP1p0jSxg+RcWFyk/JF gxxcRx+eFHetwGGwbhiYrpDioSaFb9ek2FaJY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=nlLbwzUnZ/DT7Q96ZsXMbE0NRgd6A01a6mvW2j7HPXCq0ytKfBXPK9dR9W0Y6CMqbw 7BUK2TzOIvZM757h7o5EPboTJld1veEakFHC1gRXcHavZPuuGEcdcE/EKMOjKvJ1RNTM 3Lc0g0fGWLcyQyJAf6IN+bI/wM6wR+CxwtGKI=
- List-id: Xen developer discussion <xen-devel.lists.xensource.com>
- Thread-index: AcuYAc3/8uqzEc2bRxOaoj3DrqXn2gAWg31E
- Thread-topic: [Xen-devel] reserved words in tmem.h
I fixed this in xen-unstable and I will backport to xen-4.0.
-- Keir
On 10/12/2010 00:33, "James Harper" <james.harper@xxxxxxxxxxxxxxxx> wrote:
> xen/include/public/tmem.h uses 'new' as the name of a structure, which
> is a reserved word under C++. tmem.h is included by xenctrl.h, which
> prevents anyone writing a C++ userspace app using gntdev and friends
> without rolling their own modifications to include files.
>
> new is a reserved word under C++ but not C (C99 at least), but I still
> think it's bad form to use it in an include file that could legitimately
> be used by a C++ application.
>
> Does anyone else see this as a problem?
>
> Thanks
>
> James
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel