[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Xen-devel] Re: [PATCH] Introduce dom0-min-space configuration option
On 07/26/2010 11:59 AM, Paolo Bonzini wrote:
On 07/26/2010 08:55 AM, Michal Novotny wrote:Or do you think that we should alter the message in gunzip function to say that there's an error in data stream (premature end of data stream) and that user should check for enough space on dom0?No, the gunzip function (in libxc, if I understood the context) should not even be called if pygrub could not write the file. Instead, it should print something likepygrub: No space left on device and exit. There's absolutely no error checking here: data = fs.open_file(chosencfg["kernel"]).read() (tfd, bootcfg["kernel"]) = tempfile.mkstemp(prefix="boot_kernel.", dir="/var/run/xend/boot") os.write(tfd, data) os.close(tfd) (and likewise for initrd) and that's the bug. Paolo
Paolo, that's correct but the issue here is that we don't know until we extract it from image file. But if an error occurs within the extraction we could write something like "pygrub: No space left on device" but for virt-manager and libvirt-based tools it will return an error "Boot loader didn't return any data!" so it would make other confusion to the user since user won't be able to know what's going on. Maybe the check for this message (or any other message) coming from pygrub could help and this message could be raised in the body of XendError/VmError which would make user know what the problem is at least.
Michal -- Michal Novotny<minovotn@xxxxxxxxxx>, RHCE Virtualization Team (xen userspace), Red Hat _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
Lists.xenproject.org is hosted with RackSpace, monitoring our