[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] Introduce dom0-min-space configuration option
On 07/23/2010 06:00 PM, Ian Jackson wrote:
Michal Novotny writes ("Re: [Xen-devel] [PATCH] Introduce dom0-min-space
Well, there's no other way to fix it than to implement a check for
enough space on dom0 for extracting vmlinuz and initrd files from the
image file. If it's partially extracted it's understandable that the
data are not valid input for zStream processing and therefore it runs
into Z_BUF_ERROR (-5) during the process.
No, it is not understandable that the system should continue to try to
execute a partially-extracted kernel. This needs to be fixed.
Well, if the kernel is extracted partially could it get decompressed
well? I don't think so since there's a data stream missing.
Why do you think my patch is entirely wrong?
Because you are treating the symptoms but not addressing the cause.
From what I know this is caused by insufficient disk space and
therefore the kernel and/or initrd are extracted just partially so
there's no valid end of the input data stream.
I think that making sure that the data will be extracted fully and
successfully from the image file is fixing the root cause. Or do you
think that we should alter the message in gunzip function to say that
there's an error in data stream (premature end of data stream) and that
user should check for enough space on dom0?
Michal Novotny<minovotn@xxxxxxxxxx>, RHCE
Virtualization Team (xen userspace), Red Hat
Xen-devel mailing list