[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] MSR related clean up
On Thursday 18 June 2009 17:57:06 Sheng Yang wrote: > rdmsr_safe() is used to access MSR unknown to Xen, and is not safe... I > think it is legacy. > > Also let msr_write be parity with msr_read on MSR_IA32_MISC_ENABLE. > > CC: Eddie Dong <eddie.dong@xxxxxxxxx> > Signed-off-by: Sheng Yang <sheng@xxxxxxxxxxxxxxx> Keir? -- regards Yang, Sheng > > diff -r c30742011bb8 -r 64dc4510484e xen/arch/x86/hvm/vmx/vmx.c > --- a/xen/arch/x86/hvm/vmx/vmx.c Thu Mar 12 18:48:09 2009 +0000 > +++ b/xen/arch/x86/hvm/vmx/vmx.c Thu Jun 18 17:10:22 2009 +0800 > @@ -1836,8 +1836,7 @@ > } > > if ( rdmsr_viridian_regs(ecx, &eax, &edx) || > - rdmsr_hypervisor_regs(ecx, &eax, &edx) || > - rdmsr_safe(ecx, eax, edx) == 0 ) > + rdmsr_hypervisor_regs(ecx, &eax, &edx) ) > { > regs->eax = eax; > regs->edx = edx; > @@ -2008,6 +2007,9 @@ > } > case MSR_IA32_VMX_BASIC...MSR_IA32_VMX_PROCBASED_CTLS2: > goto gp_fault; > + /* Ignore writing to these MSRs */ > + case MSR_IA32_MISC_ENABLE: > + break; > default: > if ( vpmu_do_wrmsr(regs) ) > return X86EMUL_OKAY; > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxxxxxxxx > http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |