[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-devel] [PATCH] DOM0: Adding MCA Loging support in DOM0
>>> "Ke, Liping" <liping.ke@xxxxxxxxx> 11.06.09 04:42 >>> A few small issue remain: >--- a/arch/x86_64/Kconfig Thu Jun 11 10:14:50 2009 +0800 >+++ b/arch/x86_64/Kconfig Thu Jun 11 10:25:16 2009 +0800 >@@ -471,9 +471,9 @@ > bool > > config X86_MCE >- bool "Machine check support" if EMBEDDED >- depends on !X86_64_XEN >- default y >+ bool "Machine check support" >+ depends on (!XEN_UNPRIVILEGED_GUEST) >+ default n > help > Include a machine check error handler to report hardware errors. > This version will require the mcelog utility to decode some Once again you change a default value here for no apparent reason. >--- a/arch/x86_64/kernel/mce.c Thu Jun 11 10:14:50 2009 +0800 >+++ b/arch/x86_64/kernel/mce.c Thu Jun 11 10:25:16 2009 +0800 >... >@@ -395,7 +403,9 @@ > return; > > mce_init(NULL); >+#ifndef CONFIG_X86_64_XEN > mce_cpu_features(c); >+#endif > } > > /* This conditional can be avoided if the preceding one would be moved inside the function (to cover just the entire function body). >@@ -649,6 +659,8 @@ > }; > #endif > >+struct mc_info *g_mi; >+extern void bind_virq_for_mce(void); > static __init int mce_init_device(void) > { > int err; g_mi appears to be no longer used outside of arch/x86_64/kernel/mce_dom0.c, so it could be (statically) defined there instead of here. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |