[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Patch] x86: enforce strict memory order for x2apic
>>> "Tian, Kevin" <kevin.tian@xxxxxxxxx> 25.09.08 08:55 >>> >We kick a fix by simply using 'mb' instead of 'wmb'. >This can effectively enforce program order, as args >for WRMSR are loaded from memory. Those memory loads >are ordered by mb and so does WRMSR. Alternative is The whole change looks a little dubious to me, perhaps largely as I can't spot which WRMSR (loading its arguments from memory) you're talking about. >to add a 'fence' parameter to send_IPI_mask and then >only use 'mb' in x2apic version. We think it's not >necessary to go with that complexity. On the other hand you're penalizing LAPIC systems with this, too. I'm not certain that's better than fixing the (incorrect) assumptions just in the x2APIC case. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |