Re: [Xen-devel] [PATCH] x86,amd,microcode: fix hypercall return code

[Christoph Egger <Christoph.Egger@xxxxxxx>]

On Monday 22 September 2008 14:47:38 Tian, Kevin wrote:
> >From: Christoph Egger
> >Sent: 2008å9æ22æ 20:23
> >
> >
> >Hi,
> >
> >Attached patch makes the hypercall return failure
> >if the microcode didn't apply.
> >
> >Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>
> It's weird that you don't add a 'break' if apply_microcode failed,
> unless you're sure next invocation to get_next_ucode_from_buffer
> _amd return 0... But even that, this is a bad coding style.

Yes, it is. Note, I ported that code from Linux. I don't know if
code from BSD would have been accepted due to license
incompatibilities.

Christoph

-- 
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (GeschÃftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter KomplementÃr:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
GeschÃftsfÃhrer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel