[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] xm dump-core options are useless



On Fri, Sep 05, 2008 at 11:09:39AM +0900, Akio Takebe wrote:

> >xm dump-core [-L|--live][-C| --crash] <domID> [output path]
> >
> >Didn't actually implement anything. Worse, it looks like we don't even
> >pause the domain, so it's always live (not good). What's going on?
> >
> What do you mean? Why do you think "it looks like we don't even
> pause the domain"? The following code of the patch looks like
> we do pause domain by server.xend.domain.pause(dom).

You are doing this stuff in xm which I missed due to the pointless
passing in of 'live' and 'crash' in the xend API.

This should be happening in the server not in the client if you're going
to pass the options in. In particular libvirt, but anything else that
isn't 'xm', is forced to do live dumps - not good.

I'll send a patch out shortly that implements them in the proper place.

> +    if not live:
> +        server.xend.domain.pause(dom) <<< HERE
> +
> +    try:
> +        print "dumping core of domain:%s ..." % str(dom)
> +        server.xend.domain.dump(dom, filename, live, crash)
> +    finally:
> +        if not live:
> +            server.xend.domain.unpause(dom)

BTW this is buggy if the domain was already paused.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.