[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 0/2] 32bit gdbserver-xen/libxc to debug 64bit guest
On 2/11/07 23:35, "Mukesh Rathor" <mukesh.rathor@xxxxxxxxxx> wrote:
>> The sparse tree should be overlaid a normal full gdbserver tree, so user.h
>> should be in the same place whether you've modified it or not. So I don;t
>> see why you'd need to pull in every file that includes user.h.
> You are correct, I fixed it and will resubmit the patch, I guess with
> a new email.
The new patches look much better!
>> The 32-on-64 compat layer inside Xen already builds 32-bit versions of
>> structures when building 64-bit Xen. I think they're under include/compat/
>> or something like that. It would make sense to make use of those rather than
>> hack up the original headers with explicit compat types.
> I noticed that. But I am looking for 64bit struct versions when building 32bit
> libxc. I figured coming with similar macros the other way would make the
> whole think too complex, so adding explicit compat types made sense.
> Besides, we kinda needed a debugger soon :).
Well, given we can build 64-bit domains from 32-bit dom0, I'm pretty sure we
can work out how to interrogate their state from 32-bit dom0, without
needing to modify any of the public headers. I'm sure we can clean this up
and get the improvements in without too much trouble.
Xen-devel mailing list