[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: machine check exception handling

On 22/6/07 08:52, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

>>> What issue do you think ExtInts will introduce? A crash before we get a
>>> fatal error dump onto the Xen console? This argument seems more than a
>>> little dubious to me.
>> 
>> Why - such a crash would be *very* difficult to debug, as you likely wouldn't
>> be able to guess the original reason.
> 
> Random unrecoverable hardware errors which affect execution of the lowest
> levels of your supervisor software will tend to have that effect. :-)

I could be sold on the VMX/SVM changes as part of a broader cleanup to get
rid of the humungous switch statements in svm.c and vmx.c and replace with
jump tables of entries like:
struct {
    void (*handler)(struct cpu_user_regs *);
    bool_t enable_irqs;
}

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel