[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH 0/4] [Net] Support accelerated network plugin modules
On Friday 15 June 2007 14:20:34 Keir Fraser wrote:
> On 15/6/07 13:11, "Michael Buesch" <mb@xxxxxxxxx> wrote:
> >> No use of the following please:
> >> If (foo) return 1; else return 0;
> >> Is clearer as:
> >> Return foo;
> > But it's not the same.
> > return !!foo;
> > would be the same. And yes, it does matter:
> True in general, but not the cases I've seen in this patchset, where 'foo'
> is a predicate.
Ok, if foo is a variable containing an error code, it's
better to return that error code. I assumed that foo is a
variable containing some value (counter or something).
Xen-devel mailing list