[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Make Xen headers lint-clean

On 15/6/07 00:02, "john.levon@xxxxxxx" <john.levon@xxxxxxx> wrote:

> Make ring.h and xs_wire.h lint clean. Add an unused attribute to xsd_errors if
> using GCC, so we don't get duplicate arrays in every object including the
> header.

Casting memset() to void is completely barking. Noone ever cares about the
return value, or looks at it: is half the C code in the universe not lint
clean therefore?

And xsd_errors[] already has the unused attribute; this patch does not add
it as the changeset comment suggests. Do you require to use that header file
with a compiler other than gcc?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel